Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDEV-4845 automatically use latest java and tomcat versions #14

Merged
merged 6 commits into from
Dec 7, 2024

Conversation

zspitzer
Copy link
Member

@zspitzer
Copy link
Member Author

@zspitzer zspitzer force-pushed the LDEV-4845-use-latest-java-api branch from ba1fafc to 5ffebdd Compare August 14, 2024 07:54
@@ -56,6 +56,9 @@
throw fail;
}
logger ("" );

throw "disabled for testing"!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ready to deploy?

@zspitzer
Copy link
Member Author

zspitzer commented Oct 16, 2024

@michaeloffner alas, it's still broken on linux, as the execute permissions aren't availablet from the tar files

as the extract() method now ignores all permissions
image

https://github.com/lucee/lucee-installer/actions/runs/10900055133/job/30246923113#step:5:704

I tried then using VFS listing of the files to get and manually re-apply the permissions

var files = directoryList( path="tgz://" & src, recurse=true, listinfo="query");

but that uses the ram drive stuff, which also doesn't support permissions

image

https://github.com/lucee/lucee-installer/actions/runs/10900055133/job/30246827145#step:8:2353

@zspitzer zspitzer force-pushed the LDEV-4845-use-latest-java-api branch from b94a7dd to b0e4197 Compare December 5, 2024 13:54
@zspitzer zspitzer force-pushed the LDEV-4845-use-latest-java-api branch 3 times, most recently from 0741718 to 8794822 Compare December 6, 2024 12:19
@zspitzer zspitzer force-pushed the LDEV-4845-use-latest-java-api branch from 4dc58fc to c38d693 Compare December 6, 2024 13:46
@zspitzer zspitzer merged commit ac0e926 into master Dec 7, 2024
4 of 5 checks passed
@zspitzer zspitzer deleted the LDEV-4845-use-latest-java-api branch December 7, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants