Port to Spark 3 #302
Open
Port to Spark 3 #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thelabdude
commented
Jun 22, 2020
•
thelabdude
commented
- Update to Scala 2.12
This reverts commit d823ba2.
|
Looking forward to Apache Solr team review this pull request and merge the code. |
|
Any news on this? This would be super helpful! |
|
Hello, Any news on this? This would also help me as well |
|
Any plans of merging this soon? |
alexott
reviewed
Dec 25, 2020
| logger.info(f"Fetched ${resultsIterator.getNumDocs} rows from shard $url for partition ${split.index}") | ||
| } | ||
| // TODO: Spark3 | ||
| //context.addTaskCompletionListener { (context) => |
There was a problem hiding this comment.
it could be just rewritten as context.addTaskCompletionListener[Unit] to avoid error about ambiguous reference
|
Any updates on this? We would really appreciate it if this is merged soon! |
|
It'd be great if this uplift could get merged in with a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.