Fixes for TELEPORTER BASIC #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the player ypos and yaw also need to be transformed to the teleporter's values Also re-instate commented out code that changes automap layer after teleporting
jerethk
force-pushed
the
FIX_TELEPORTER_BASIC
branch
from
df7b4e8 to
6f323f1
Compare
luciusDXL
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple minor things had to be done to make TELEPORTER BASIC work as you would expect.
s_playerYPosands_playerYawvalues also need to be transformed to the teleporter's values for the player to correctly teleport to the new positionAlso re-instated the commented out code that changes automap layer after teleporting. This brings back vanilla behaviour.
I do not believe that this amendment needs to be an optional game setting, because TELEPORTER BASIC is a recent discovery that existing mods do not use.