Externalise pickups #475
Merged
Externalise pickups #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- index to weaponIndex - item and value to playerItem and playerAmmo - ITYPE_KEY_ITEM to ITYPE_USABLE - ITYPE_INV_ITEM to ITYPE_CODEKEY - s_invItemPickupSnd to s_objectivePickupSnd�- s_wpnPickupSnd to s_itemPickupSnd
luciusDXL
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was done with projectiles and effects, I've externalised pickups data to a JSON.
The first commit in this PR renames a number of constants and variables to more accurately reflect what they are.