Skip to content

Commit

Permalink
fix: temporarily remove config validation check for backend (#3688)
Browse files Browse the repository at this point in the history
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
geoffreyangus and pre-commit-ci[bot] authored Oct 4, 2023
1 parent e46a989 commit 68c6cdf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ludwig/config_validation/checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,8 @@ def _get_llm_model_config(model_name: str) -> AutoConfig:
return AutoConfig.from_pretrained(model_name)


@register_config_check
# TODO(geoffrey, arnav): uncomment this when we have reconciled the config with the backend kwarg in api.py
# @register_config_check
def check_llm_quantization_backend_incompatibility(config: "ModelConfig") -> None: # noqa: F821
"""Checks that LLM model type with quantization uses the local backend."""
if config.model_type != MODEL_LLM:
Expand Down
3 changes: 3 additions & 0 deletions tests/ludwig/config_validation/test_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,9 @@ def test_retrieval_config_semantic_type():
ModelConfig.from_dict(config)


@pytest.mark.skip(
reason="TODO(geoffrey, arnav): re-enable this when we have reconciled the config with the backend kwarg in api.py"
)
def test_check_llm_quantization_backend_incompatibility():
config = yaml.safe_load(
"""
Expand Down

0 comments on commit 68c6cdf

Please sign in to comment.