-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example] Fix llm_finetune example json part #3461
Conversation
Hey! Thanks for the contribution. What was the issue you ran into with using the LLM as an encoder? It should work as is as long as the model type is ECD. Currently Ludwig master only supports Ray 2.4. |
9db6213
to
4c878cf
Compare
Json validation error.
|
634f20f
to
85f4b42
Compare
Unit Test Results 4 files ±0 4 suites ±0 55m 4s ⏱️ -51s Results for commit bcdf349. ± Comparison against base commit 60f1416. This pull request skips 2 tests.
♻️ This comment has been updated with latest results. |
Hmm, I'm not sure you need to add What is the exact issue you're running into with the existing config? |
@arnavgarg1
|
85f4b42
to
bcdf349
Compare
I got a Ray 2.3 docker image, with above config change to
|
bcdf349
to
6ffb182
Compare
Convert the change back to
|
6ffb182
to
fd3cc43
Compare
@chongxiaoc can you potentially try bumping Deepspeed to 0.9.2 and seeing if this error persists? From what I remember, this error used to show up on older versions of deepspeed |
@arnavgarg1 Just adding See training running now
|
Nice! So deepspeed isn't a problem then? What version of deepspeed are you on? Thanks for working through this so patiently! |
|
Perfect, thanks! |
llm_finetune
example is using out-dated json format.This PR should fix it.
However, my testing env is using Ray 2.5 and still get failure in model training part.