Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Make sure that the "hyperopt" directory in the local repository path is deleted after test run is completed #3736

Conversation

alexsherstinsky
Copy link
Collaborator

Scope

When the test tests/integration_tests/test_automl.py::test_auto_train is executed, the "hyperopt" directory remains in the main repository directory. We clean this directory up by passing the output_directory argument to auto_train(). By making this output_directory a relative path from the tmpdir fixture, it will be automatically deleted upon the completion of the test.

Code Pull Requests

Please provide the following:

  • a clear explanation of what your code does
  • if applicable, a reference to an issue
  • a reproducible test for your PR (code, config and data sample)

Documentation Pull Requests

Note that the documentation HTML files are in docs/ while the Markdown sources are in mkdocs/docs.

If you are proposing a modification to the documentation you should change only the Markdown files.

api.md is automatically generated from the docstrings in the code, so if you want to change something in that file, first modify ludwig/api.py docstring, then run mkdocs/code_docs_autogen.py, which will create mkdocs/docs/api.md .

…gets cleaned up upon the completion of the "test_auto_train()" test.
@github-actions
Copy link

Unit Test Results

  6 files  ±0    6 suites  ±0   17m 57s ⏱️ - 4m 56s
12 tests ±0    7 ✔️  -   2    5 💤 +  2  0 ±0 
60 runs  ±0  30 ✔️  - 12  30 💤 +12  0 ±0 

Results for commit 9eb158e. ± Comparison against base commit c711d0a.

This pull request skips 2 tests.
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

@alexsherstinsky alexsherstinsky marked this pull request as ready for review October 17, 2023 22:26
@justinxzhao justinxzhao merged commit f7010f3 into ludwig-ai:master Oct 18, 2023
16 of 17 checks passed
@alexsherstinsky alexsherstinsky deleted the bugfix/ISSUE-3734/alexsherstinsky/tests/integration_test_and_slow_tests_fail_in_continuous_integration-2023_10_17-11 branch October 18, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants