Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base.py #3750

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Update base.py #3750

merged 1 commit into from
Oct 25, 2023

Conversation

jetaudio
Copy link
Contributor

Missing config and model variable in line 321

Code Pull Requests

Please provide the following:

  • fix error missing config and model positional variable in line 321 file base.py

Missing config and model variable in line 321
@github-actions
Copy link

Unit Test Results

  6 files  ±0    6 suites  ±0   20m 2s ⏱️ -12s
12 tests ±0    7 ✔️  -   2    5 💤 +  2  0 ±0 
60 runs  ±0  30 ✔️  - 12  30 💤 +12  0 ±0 

Results for commit 4385581. ± Comparison against base commit 0620b00.

This pull request skips 2 tests.
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

@tgaddair
Copy link
Collaborator

Thanks for the PR @jetaudio, looks like this was an regression introduced in #3709, which removed the config and model from kwargs.

@geoffreyangus geoffreyangus self-requested a review October 25, 2023 21:52
@geoffreyangus geoffreyangus merged commit 6b18a8e into ludwig-ai:master Oct 25, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants