Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Restrict "fsspec" to not include the latest version "2023.10.0" #3752

Conversation

alexsherstinsky
Copy link
Collaborator

Scope

The version 2023.10.0 or the fsspec library was released on 10/21/2023. Unfortunately, it breaks the builder.py::as_dataset() method of the HuggingFace "datasets" library version in use with the error NotImplementedError: Loading a dataset cached in a LocalFileSystem is not supported. being raised. Hence, we restrict the fsspec version for the time being.

Code Pull Requests

Please provide the following:

  • a clear explanation of what your code does
  • if applicable, a reference to an issue
  • a reproducible test for your PR (code, config and data sample)

Documentation Pull Requests

Note that the documentation HTML files are in docs/ while the Markdown sources are in mkdocs/docs.

If you are proposing a modification to the documentation you should change only the Markdown files.

api.md is automatically generated from the docstrings in the code, so if you want to change something in that file, first modify ludwig/api.py docstring, then run mkdocs/code_docs_autogen.py, which will create mkdocs/docs/api.md .

…use it breaks the "builder.py::as_dataset()" method of the HuggingFace "datasets" library.
@alexsherstinsky alexsherstinsky marked this pull request as ready for review October 23, 2023 06:26
@github-actions
Copy link

Unit Test Results

  6 files  ±0    6 suites  ±0   20m 52s ⏱️ +38s
12 tests ±0    7 ✔️  -   2    5 💤 +  2  0 ±0 
60 runs  ±0  30 ✔️  - 12  30 💤 +12  0 ±0 

Results for commit cab30eb. ± Comparison against base commit 0620b00.

This pull request skips 2 tests.
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

@justinxzhao
Copy link
Contributor

Thanks @alexsherstinsky!

@justinxzhao justinxzhao merged commit 8b423f1 into ludwig-ai:master Oct 23, 2023
18 checks passed
@alexsherstinsky alexsherstinsky deleted the maintenance/alexsherstinsky/requirements/restrict_fsspec_to_pre_10_21_2023_release-2023_10_22-14 branch October 23, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants