Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update .travis.yml #91

wants to merge 1 commit into from

Conversation

RuiSiang
Copy link

@RuiSiang RuiSiang commented May 8, 2020

Changed dependency, as proposed in PR #84

Changed dependency
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.103% when pulling b5f738a on RuiSiang:patch-1 into c177b65 on lukechilds:master.

@lukechilds
Copy link
Owner

lukechilds commented May 8, 2020

Thanks for taking the time to submit this. Why is this change needed?

@RuiSiang
Copy link
Author

RuiSiang commented May 8, 2020

After this PR, try merging PR #84 again.

libjpeg-dev and libjpeg8-dev are for different libraries. libjpeg-dev is for libjpeg-turbo, while libjpeg8-dev is for the original libjpeg. Canvas changed dependencies a while back. That's why tests failed starting from PR #64(the PR prompt travis to compile canvas while missing a dependency).

Another reason is that libjpeg8-dev is not available on Debian Jessie, might be another reason to change it

Hope that clarifies.

@lukechilds
Copy link
Owner

lukechilds commented May 8, 2020

After this PR, try merging PR #84 again.

Merging this won't help #84, see #90 (comment).

Canvas changed dependencies a while back. That's why tests failed starting from PR #64(the PR prompt travis to compile canvas while missing a dependency)

But tests are passing in master with libjpeg8-dev and canvas@^2.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants