Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

Upgrade to elm 19 and the latest elm-css #188

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stephenreddek
Copy link

Closes out #179

I'm not very familiar with elm-css so I'm not sure if I'm following best practices. The newest version is fundamentally very different from how it was being used in this project. I hope this is the right direction! I am completely willing to change how the css is being done here if I have implemented it incorrectly.

I thought the addition of elm-live would make it easier to get started for other contributors, but I can remove that if it is not in the right direction.

I noticed that the browser images that go around the screenshots are not working while testing. The styles being applied are the same and it works if you update the url to be at assets/ so I imagine it will work when deployed.

@prikhi
Copy link
Contributor

prikhi commented Oct 25, 2019

Thanks for putting in the work! It might be a little while before I am able to review & test this.

@joelclermont
Copy link
Collaborator

@stephenreddek Totally agree with @prikhi. Thank you so much for the contribution! I'm a bit overbooked through the end of the month, but I will give this a careful review as soon as I can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants