Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to snake_case builtins and PNC #27

Merged
merged 12 commits into from
Jan 24, 2025
Merged

Upgrade to snake_case builtins and PNC #27

merged 12 commits into from
Jan 24, 2025

Conversation

lukewilliamboswell
Copy link
Owner

No description provided.

smores56
smores56 reviewed Jan 10, 2025
View reviewed changes
Copy link

@smores56 smores56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides these comments, Parser.roc and String.roc need some love on their doc comments. Both PNC and snake_case

package/Markdown.roc Outdated Show resolved Hide resolved
package/Markdown.roc Outdated Show resolved Hide resolved
package/Markdown.roc Outdated Show resolved Hide resolved
package/Markdown.roc Outdated Show resolved Hide resolved
package/Parser.roc Outdated Show resolved Hide resolved
package/Parser.roc Outdated Show resolved Hide resolved
package/Parser.roc Outdated Show resolved Hide resolved
package/Parser.roc Outdated Show resolved Hide resolved
package/Parser.roc Outdated Show resolved Hide resolved
package/Parser.roc Show resolved Hide resolved
@lukewilliamboswell lukewilliamboswell merged commit 252581c into main Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smores56 smores56 smores56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewilliamboswell @smores56