Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos #1194

Closed
wants to merge 1 commit into from
Closed

fix: typos #1194

wants to merge 1 commit into from

Conversation

yash251
Copy link

@yash251 yash251 commented Jan 7, 2025

No description provided.

@yash251
Copy link
Author

yash251 commented Jan 8, 2025

following up here @CJ42 @mustafademiray

@CJ42
Copy link
Member

CJ42 commented Jan 8, 2025

@yash251 thank you for your PR.
Unfortunately, we have introduced spellcheck in our CI to fix any grammar errors in #1172
So this PR might not be applicable anymore once it is merged.

@yash251
Copy link
Author

yash251 commented Jan 8, 2025

i see it is merged a few mins ago, is it live yet with all the changes, I can take a look in a week again

@CJ42
Copy link
Member

CJ42 commented Jan 8, 2025

i see it is merged a few mins ago, is it live yet with all the changes, I can take a look in a week again

Yes I have merged the PR for the spellcheck.
I see now you have merge conflicts. Could you rebase your PR and see if you any other typo left?
If not, we can close your PR.

@yash251
Copy link
Author

yash251 commented Jan 8, 2025

closing this as I have created a new PR pulling all the changes after spellchecker
#1196

@yash251 yash251 closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants