Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create guide to set LSP8 NFT metadata #826

Merged
merged 11 commits into from
Jan 12, 2024
Merged

create guide to set LSP8 NFT metadata #826

merged 11 commits into from
Jan 12, 2024

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Jan 10, 2024

No description provided.

@CJ42 CJ42 requested a review from Hugoo as a code owner January 10, 2024 17:01
Copy link
Contributor

@Hugoo Hugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the use of NFT vs LSP8 vs Identifiable Digital Asset shoulb be more precise.

Sometimes it says NFT, sometimes not.

I think "Identifiable Digital Asset" is the best way.

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Deployed with Cloudflare Pages ☁️ 🚀 🆗

@CJ42 CJ42 force-pushed the guide-nft-metadata branch from d05ee4d to 2a5bea0 Compare January 12, 2024 10:01
Copy link
Contributor

@Hugoo Hugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!!

@fhildeb
Copy link
Contributor

fhildeb commented Jan 12, 2024

LGTM

@Hugoo Hugoo merged commit cb9d218 into main Jan 12, 2024
2 checks passed
@Hugoo Hugoo deleted the guide-nft-metadata branch January 12, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants