Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add LSP7Votes and LSP8Votes extension to support LSP-based Governance #980

Merged
merged 17 commits into from
Nov 29, 2024
Merged

feat: Add LSP7Votes and LSP8Votes extension to support LSP-based Governance #980

merged 17 commits into from
Nov 29, 2024

Conversation

YamenMerhi
Copy link
Member

What does this PR introduce?

🚀 Feature

  • Add implementation of LSP7 and LSP8 required interface for supporting governance compliant to ERC5805.

PR Checklist

  • Wrote Tests
  • Wrote & Generated Documentation (readme/natspec/dodoc)
  • Ran npm run lint && npm run lint:solidity (solhint)
  • Ran npm run format (prettier)
  • Ran npm run build
  • Ran npm run test

skimaharvey
skimaharvey approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@skimaharvey skimaharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CJ42
CJ42 reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create the InitAbstract version as well.

packages/lsp7-contracts/contracts/LSP7Constants.sol Show resolved Hide resolved
packages/lsp7-contracts/contracts/LSP7DigitalAsset.sol Outdated Show resolved Hide resolved
packages/lsp7-contracts/contracts/LSP7DigitalAsset.sol Outdated Show resolved Hide resolved
packages/lsp7-contracts/contracts/LSP7DigitalAsset.sol Outdated Show resolved Hide resolved
packages/lsp7-contracts/contracts/LSP7DigitalAssetInitAbstract.sol Outdated Show resolved Hide resolved
packages/lsp7-contracts/contracts/extensions/LSP7Votes.sol Outdated Show resolved Hide resolved
packages/lsp7-contracts/contracts/extensions/LSP7Votes.sol Outdated Show resolved Hide resolved
packages/lsp7-contracts/contracts/extensions/LSP7Votes.sol Outdated Show resolved Hide resolved
packages/lsp7-contracts/contracts/extensions/LSP7Votes.sol Show resolved Hide resolved
packages/lsp7-contracts/tests/LSP7Votes.test.ts Outdated Show resolved Hide resolved
@CJ42 CJ42 merged commit 25e7ff9 into develop Nov 29, 2024
2 checks passed
@CJ42 CJ42 deleted the governance-lsp branch November 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJ42 CJ42 CJ42 approved these changes

@skimaharvey skimaharvey skimaharvey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YamenMerhi @CJ42 @skimaharvey