chore: test code quality improvements (#520)

.editorconfig

@@ -4,7 +4,7 @@ root = true
 end_of_line = lf
 insert_final_newline = true
 
-[*.{js,json,yml}]
+[*.{js,ts,json,yml}]
 charset = utf-8
 indent_style = space
 indent_size = 2

.eslintrc.cjs

@@ -78,8 +78,6 @@ module.exports = {
       files: ['**/*.spec.ts'],
       extends: ['plugin:playwright/playwright-test'],
       rules: {
-        'import/order': 'off',
-        '@typescript-eslint/no-unused-vars': 'off',
         'playwright/no-standalone-expect': 'off',
         'playwright/no-networkidle': 'off',
         'playwright/no-skipped-test': 'off',

app.vue

@@ -120,9 +120,7 @@ const setupNetwork = async () => {
     }
   } else {
     console.warn(
-      `Invalid network: ${network}, valid networks are ${SUPPORTED_NETWORK_IDS.join(
-        ', '
-      )}`
+      `Invalid network: ${network}, valid networks are ${SUPPORTED_NETWORK_IDS.join(', ')}`
     )
   }
 }

components/__tests__/AppLinks.spec.ts

@@ -4,10 +4,6 @@ import { describe, expect, it } from 'vitest'
 import AppLinks from '@/components/AppLinks.vue'
 
 describe('AppLinks', () => {
-  const profile: Profile = {
-    address: '0x1234567890abcdef1234567890abcdef12345678',
-  }
-
   it('should render empty links', async () => {
     const component = await renderSuspended(AppLinks, {
       props: {

components/__tests__/AssetStandardBadge.spec.ts

@@ -1,5 +1,4 @@
 import { renderSuspended } from '@nuxt/test-utils/runtime'
-import { fireEvent, screen } from '@testing-library/vue'
 import { beforeEach, describe, expect, it } from 'vitest'
 
 import AssetStandardBadge from '@/components/AssetStandardBadge.vue'

components/__tests__/FollowCounters.spec.ts

@@ -1,9 +1,10 @@
 import { renderSuspended } from '@nuxt/test-utils/runtime'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it } from 'vitest'
 
-import type { ProfileFollowers } from '@/types/profile'
 import FollowCounters from '../FollowCounters.vue'
 
+import type { ProfileFollowers } from '@/types/profile'
+
 describe('FollowCounters', () => {
   beforeEach(() => {
     useIntl().setupIntl(defaultConfig)

components/__tests__/LinkButton.spec.ts

@@ -4,10 +4,6 @@ import { describe, expect, it } from 'vitest'
 import LinkButton from '@/components/LinkButton.vue'
 
 describe('LinkButton', () => {
-  const profile: Profile = {
-    address: '0x1234567890abcdef1234567890abcdef12345678',
-  }
-
   it('should render empty state', async () => {
     const component = await renderSuspended(LinkButton, {})
 

domains/graph/components/__tests__/AppNavbarProfileSearchGraph.spec.ts

@@ -1,5 +1,4 @@
 import { renderSuspended } from '@nuxt/test-utils/runtime'
-import { fireEvent, screen } from '@testing-library/vue'
 import { beforeEach, describe, expect, it } from 'vitest'
 
 import AppNavbarProfileSearchGraph from '../AppNavbarProfileSearchGraph.vue'

domains/grid/components/__tests__/GridFloatingMenu.spec.ts

@@ -1,6 +1,7 @@
 import { renderSuspended } from '@nuxt/test-utils/runtime'
 import { createTestingPinia } from '@pinia/testing'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
+
 import GridFloatingMenu from '../GridFloatingMenu.vue'
 
 vi.mock('/utils/getCurrentProfileAddress', () => ({

domains/grid/utils/__tests__/buildGrid.spec.ts

@@ -1,5 +1,5 @@
-import { e } from 'pinia-orm/dist/shared/pinia-orm.ed84a779'
 import { describe, expect, it } from 'vitest'
+
 import { buildGrid } from '../buildGrid'
 
 describe('buildGrid', () => {

domains/grid/utils/__tests__/compareGridWidgets.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { compareGridWidgets } from '../compareGridWidgets'
 
 describe('compareGridWidgets', () => {

domains/grid/utils/__tests__/compareGrids.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { compareGrids } from '../compareGrids'
 
 describe('compareGrids', () => {

domains/grid/utils/__tests__/createGridId.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { createGridId } from '../createGridId'
 
 describe('createGridId', () => {

domains/grid/utils/__tests__/createWidgetObject.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it, vi } from 'vitest'
+
 import { createWidgetObject } from '../createWidgetObject'
 
 vi.mock('/domains/grid/utils/generateItemId', () => ({

domains/grid/utils/__tests__/gridParser.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { parsePlatformInput } from '../gridParser'
 
 const YOUTUBE_IFRAME_ALLOW =

domains/grid/utils/__tests__/gridToConfig.spec.ts

@@ -1,4 +1,5 @@
-import { describe, expect, it, vi } from 'vitest'
+import { describe, expect, it } from 'vitest'
+
 import { gridToConfig } from '../gridToConfig'
 
 describe('gridToConfig', () => {

domains/grid/utils/__tests__/purifyGridConfig.spec.ts

@@ -1,4 +1,5 @@
-import { describe, expect, it, vi } from 'vitest'
+import { describe, expect, it } from 'vitest'
+
 import { purifyGridConfig } from '../purifyGridConfig'
 
 describe('purifyGridConfig', () => {

pages/settings/data-provider/__tests__/index.spec.ts

@@ -1,8 +1,7 @@
 import { renderSuspended } from '@nuxt/test-utils/runtime'
 import { createTestingPinia } from '@pinia/testing'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it } from 'vitest'
 
-import { useAppStore } from '@/stores/app'
 import Index from '../index.vue'
 
 describe('Settings data-provider page', () => {

services/ipfs/formdata-base-client.ts

@@ -131,9 +131,7 @@ export class BaseFormDataUploader {
             error = (error as any).error || error
             throw new NetworkError(
               new Error(
-                `unknown server response while pinning File to IPFS: ${
-                  error || response.status
-                }`
+                `unknown server response while pinning File to IPFS: ${error || response.status}`
               ),
               response.status
             )

tests/e2e/404.spec.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test'
+
 import { test } from './helpers/fixtures'
 
 test('can access 404 page', async ({ page }) => {

tests/e2e/index.spec.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test'
+
 import { test } from './helpers/fixtures'
 
 test('landing page when no browser extension', async ({ page }) => {

utils/__tests__/assetChecks.spec.ts

@@ -1,10 +1,6 @@
+import { LSP4_TOKEN_TYPES } from '@lukso/lsp-smart-contracts'
 import { describe, expect, test } from 'vitest'
 
-import { LSP4_TOKEN_TYPES } from '@lukso/lsp-smart-contracts'
-import type {
-  SelectProfileOption,
-  SelectStringOption,
-} from '@lukso/web-components'
 import {
   getBalance,
   hasBalance,

utils/__tests__/assetTypes.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from 'vitest'
+
 import { getAssetType } from '../assetTypes'
 
 test('getAssetType', () => {

utils/__tests__/cloneObject.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { cloneObject } from '../cloneObject'
 
 describe('cloneObject', () => {

utils/__tests__/decodeParameter.spec.ts

@@ -1,5 +1,6 @@
 import { describe, expect, test, vi } from 'vitest'
 import ABICoder from 'web3-eth-abi'
+
 import { decodeParameter } from '../decodeParameter'
 
 describe('decodeParameter function', () => {

utils/__tests__/deepEqual.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { deepEqual } from '../deepEqual'
 
 describe('deepEqual', () => {

utils/__tests__/externalUrls.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, test } from 'vitest'
+
 import {
   universalPageProfileUrl,
   universalSwapsProfileUrl,

utils/__tests__/groupAttributes.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { groupAttributes } from '../groupAttributes'
 
 describe('groupAttributes', () => {

utils/__tests__/hexToNumber.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, test, vi } from 'vitest'
+
 import { hexToNumber } from '../hexToNumber'
 
 describe('hexToNumber function', () => {

utils/__tests__/hexToUtf8.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, test, vi } from 'vitest'
+
 import { hexToUtf8 } from '../hexToUtf8'
 
 describe('hexToUtf8 function', () => {

utils/__tests__/isValidURL.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { isValidURL } from '../isValidURL'
 
 describe('isValidURL', () => {

utils/__tests__/paddedToAddress.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from 'vitest'
+
 import { paddedToAddress } from '../paddedToAddress'
 
 test('paddedToAddress should remove zero padding from an address', async () => {

utils/__tests__/queryParamsString.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { queryParamsString } from '../queryParamsString'
 
 describe('queryParamsString', () => {

utils/__tests__/slug.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { slug } from '../slug'
 
 describe('slug', () => {

utils/__tests__/sort.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { stringSort } from '../sort'
 
 describe('stringSort', () => {

utils/__tests__/tokenConversionWithDecimals.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import {
   fromTokenUnitWithDecimals,
   toTokenUnitWithDecimals,

utils/__tests__/truncate.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import { truncate } from '../truncate'
 
 describe('truncate', () => {

utils/__tests__/unflatArray.spec.ts

@@ -1,4 +1,5 @@
-import { describe, expect, test } from 'vitest'
+import { expect, test } from 'vitest'
+
 import { unflatArray } from '../unflatArray'
 
 test('handles consecutive indexes', () => {

utils/__tests__/validateLspMetadata.spec.ts

@@ -1,9 +1,9 @@
 import { describe, expect, test } from 'vitest'
+
 import {
   validateAssets,
   validateAttributes,
   validateDescription,
-  validateImage,
   validateImages,
   validateLinks,
   validateName,

utils/__tests__/validators.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, test } from 'vitest'
+
 import {
   assertAddress,
   assertAddresses,