Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

feat: send LSP7/LSP8 #113

Merged
merged 48 commits into from
Oct 20, 2023
Merged

feat: send LSP7/LSP8 #113

merged 48 commits into from
Oct 20, 2023

Conversation

dzbo
Copy link
Collaborator

@dzbo dzbo commented Oct 17, 2023 •
edited
Loading

Ticket ID

DEV-2723
DEV-2724
DEV-8688
DEV-8713
DEV-8697
DEV-8730
DEV-8693

Description

  • send LSP7/LSP8 assets
  • fix total supply calculation that didn't include decimals
  • non divisible token validation when sending assets
  • add link to nav icon that open current wallet
  • add contract types from typechain
  • fix issue when user could scroll when modal was open
  • add asset balance in asset details page
  • truncate long balances in asset cards
  • convert all images to base64 for future caching
  • when no NFT icon is avail fallback to first image from images collection
  • add loading state to send card
  • move pinia storeToRefs to auto impoerts
  • reorganize types into individual files
  • simplify asset types
  • replace interface check with contract based instead of erc725js
  • make creator box as clickable element

Sorry for big PR, next time I try to split into smaller ones 😅

@Hugoo
Copy link
Contributor

Hugoo commented Oct 17, 2023

Task linked: DEV-2723 As a User, I can send a LSP7 asset

@dzbo dzbo marked this pull request as ready for review October 18, 2023 13:34
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

Deployed with Cloudflare Pages ☁️ 🚀 🆗

@dzbo dzbo requested a review from doubleppereira October 20, 2023 07:35
@dzbo
Merge branch 'develop' of github.com:lukso-network/wallet.universalpr…
e138130 
…ofile.cloud into feat/send-lsp7-lsp8-DEV-2723
@dzbo dzbo requested a review from doubleppereira October 20, 2023 08:53
doubleppereira
doubleppereira approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@doubleppereira doubleppereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did a quick run through but not in context of everything

@dzbo dzbo merged commit b8035a7 into develop Oct 20, 2023
2 checks passed
@dzbo dzbo deleted the feat/send-lsp7-lsp8-DEV-2723 branch October 20, 2023 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@doubleppereira doubleppereira doubleppereira approved these changes

@richtera richtera richtera approved these changes

@Hugoo Hugoo Awaiting requested review from Hugoo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzbo @Hugoo @richtera @doubleppereira