This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
fix: Some upgrades erc725.js and some minor npms for security fixes #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dzbo NOTE: When I ran the test locally the 404 page was a few pixels off. Not sure what that's about, but I am assuming it's just a local thing, but FYI. |
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
Hugoo
approved these changes
Nov 3, 2023
.env.example
Outdated
| ALGOLIA_APPLICATION_ID=YOUR_ALGOLIA_APPLICATION_ID | ||
| ALGOLIA_API_KEY=YOUR_ALGOLIA_API_KEY | ||
| ALGOLIA_APPLICATION_ID=YHFN1WRCR5 | ||
| ALGOLIA_API_KEY=5981bf15ffc7630353478168f2574228 |
There was a problem hiding this comment.
??? Is this supposed to be public?!
There was a problem hiding this comment.
Argh, how did that get in there.
There was a problem hiding this comment.
Fixing it ended up in the example and not in .env.
There was a problem hiding this comment.
Removed. It's only inside of this PR note. I removed it from git history and the repo is not public.
There was a problem hiding this comment.
It's actually a public key for search anyways, but better not in the repo.
dzbo
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades for erc725.js
Upgrades for some minors npms to capture security fixes.