This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
feat: Add swHasUpgrade but prevent auto reload. #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grade and reload of service worker
|
Task linked: DEV-11966 Remove additional page reload |
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
dzbo
suggested changes
Oct 30, 2024
|
@richtera we are getting there, can you check why lint is complaining? |
See above comment about "pages" |
dzbo
approved these changes
Nov 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ID
https://app.clickup.com/t/2645698/DEV-11966
Description
provide a new boolean called swHasUpgrade using provide('swHasUpgrade', hasUpgrade)
the value will be set if an upgrade is detected during the initial page load. The upgrade will be allowed,
but the new version will not be initialized such that we can notify the user they can reload to get an upgrade
next time. It should automatically upgrade on the next full navigation to another page anyways.