feat: add clean schedule and resolve npm audit issues #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any changes I need to make for this? |
|
@afittz sorry, missed this when it came in, looks good, maybe add a few examples in the description for the |
|
@theburningmonk Great suggestion! I'll add some examples. |
|
@theburningmonk Sorry for the delay in getting this cleaned up!!! |
Open
| ``` | ||
|
|
||
| The CleanSchedule parameter supports any Schedule Expression for a CloudWatch event. The default uses a rate expression that will execute hourly, however you can easily specify any desired number of minutes/hours/days between runs or use a cron expression. Examples: `rate(12 hours)` or `rate(1 day)`. More details on valid options can be found on the [Amazon CloudWatch Events website](https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/ScheduledEvents.html). |
There was a problem hiding this comment.
I think they're called "EventBridge events" now
|
Why was this not merged to the main release branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
CleanSchedulewith a default value ofrate(1 hour).Additional changes:
aws-sdknpm package to devDependencies since AWS includes this in the runtime image and it increases the deployment size. (https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html)I'm happy to change/remove anything; just let me know!