Rd 7813 go tracer flaky unit test testlambdahandlere2elocal ctxhttp tra #29
Conversation
…dahandlere2elocal-ctxhttp-tra
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 74.05% 72.19% -1.86%
==========================================
Files 7 7
Lines 424 446 +22
==========================================
+ Hits 314 322 +8
- Misses 64 73 +9
- Partials 46 51 +5
Continue to review full report at Codecov.
|
| assert.NoError(e.T(), err) | ||
| assert.Equal(e.T(), 4, len(spans.endFileSpans)) | ||
| assert.NoError(e.T(), deleteAllFiles()) | ||
| cfg.MaxSizeForRequest = oldConfig |
There was a problem hiding this comment.
Can you move it to afterEach or beforeEach?
wrapper.go
Outdated
| //Format details | ||
| func (s *LogFormatter) Format(entry *log.Entry) ([]byte, error) { | ||
| timestamp := time.Now().Local().Format("2006-01-02 15:04:05") | ||
| msg := fmt.Sprintf("#LUMIGO#-%s-%s-message:%s ", timestamp, strings.ToUpper(entry.Level.String()), entry.Message) |
There was a problem hiding this comment.
Are you sure that it keeps the previous format? Can you send me an image of an example of the new log?
There was a problem hiding this comment.
#LUMIGO# 2022-04-14 16:27:22-ERROR message:unable to fetch Amazon Trace ID
There was a problem hiding this comment.
We don't have the "message" in the other tracers and it i looks a bit different, check the image
No description provided.