Merge pull request #577 from Tieske/luacov-mandatory

fix(cli) fail if LuaCov is specified but unavailable
lunarmodules · Jul 20, 2018 · 10f3fff · 10f3fff
2 parents 997514a + 6367736
commit 10f3fff
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/busted/modules/luacov.lua b/busted/modules/luacov.lua
@@ -4,7 +4,7 @@ return function()
     local result, luacov = pcall(require, 'luacov.runner')
 
     if not result then
-      return print('LuaCov not found on the system, try running without --coverage option, or install LuaCov first')
+      return nil, 'LuaCov not found on the system, try running without --coverage option, or install LuaCov first'
     end
 
     -- call it to start
@@ -16,6 +16,7 @@ return function()
     table.insert(luacov.configuration.exclude, 'luassert%.')
     table.insert(luacov.configuration.exclude, 'say%.')
     table.insert(luacov.configuration.exclude, 'pl%.')
+    return true
   end
 
   return loadLuaCov

diff --git a/busted/runner.lua b/busted/runner.lua
@@ -56,7 +56,11 @@ return function(options)
 
   -- If coverage arg is passed in, load LuaCovsupport
   if cliArgs.coverage then
-    luacov()
+    local ok, err = luacov()
+    if not ok then
+      io.stderr:write(appName .. ': error: ' .. err .. '\n')
+      exit(1, forceExit)
+    end
   end
 
   -- If auto-insulate is disabled, re-register file without insulation