Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Optimize contains_call() by adding memoization #105

Merged
merged 1 commit into from
May 24, 2024
Merged

perf: Optimize contains_call() by adding memoization #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/luacheck/stages/resolve_locals.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,26 @@ local function in_scope(var, index)
end

local function contains_call(node)
if node._contains_call ~= nil then
-- return cached result
return node._contains_call
end

if node.tag == "Call" or node.tag == "Invoke" then
node._contains_call = true
return true
end

if node.tag ~= "Function" then
for _, sub_node in ipairs(node) do
if type(sub_node) == 'table' and contains_call(sub_node) then
node._contains_call = true
return true
end
end
end

node._contains_call = false
return false
end

Expand Down
Loading