Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Info: Replace Neofetch with Fastfetch #826

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

sonic2kk
Copy link
Contributor

@sonic2kk sonic2kk commented Aug 12, 2024

Adds Fastfetch; a commandline utility for pretty-printing system information across Linux distributions (and other operating systems as well). The capitalization I used for Fastfetch was taken from the project's README.

It is similar to Neofetch, but that project was discontinued some months ago. Fastfetch seems to be the recommended replacement (I have been using it as a replacement on my Arch system for a while now), although it should be noted that it is an entirely different project that was not explicitly created to replace Neofetch, it has simply become the de-facto replacement. For this reason, I opted to remove Neofetch and brand this PR as replacing it with Fastfetch, all in the same PR.

Fastfetch is FOSS (available on GitHub), licensed under the terms of the MIT license.

Summary by Sourcery

Replace Neofetch with Fastfetch in the documentation to reflect the discontinuation of Neofetch and the adoption of Fastfetch as its de-facto replacement.

Documentation:

  • Replace Neofetch with Fastfetch in the list of system information tools in the README.

Copy link
Contributor

sourcery-ai bot commented Aug 12, 2024

Reviewer's Guide by Sourcery

This pull request replaces the discontinued Neofetch utility with Fastfetch, a similar but actively maintained tool for displaying system information. The change is implemented by updating the README.md file to remove the entry for Neofetch and add a new entry for Fastfetch in the list of system monitoring tools.

File-Level Changes

Files Changes
README.md Added Fastfetch to the list of system monitoring tools with a brief description and link to its GitHub repository
README.md Removed the entry for Neofetch from the list of system monitoring tools

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Aug 12, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sonic2kk - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

luong-komorebi
luong-komorebi previously approved these changes Aug 13, 2024
README.md Outdated Show resolved Hide resolved
- [![Open-Source Software][oss icon]](https://github.com/nicolargo/glances) [Glances](https://nicolargo.github.io/glances/) - Glances is a system monitoring terminal application that shows you your disk usage, ram usage, and cpu usage in a very friendly way using the Ncurses programming library. It is tolerant to windows resizing, and very low on system ram usage.
- [![Open-Source Software][oss icon]](https://github.com/aksakalli/gtop) [gtop](https://github.com/aksakalli/gtop) - A system monitoring dashboard for terminal. Think 'graphical top', with bar charts, line graphs, pie charts, and etc.
- [![Open-Source Software][oss icon]](https://github.com/hishamhm/htop) [htop](https://htop.dev/) - An interactive process viewer for Unix systems with improved features and user experience.
- [![Open-Source Software][oss icon]](https://github.com/sharkdp/hyperfine) [hyperfine](https://github.com/sharkdp/hyperfine) - A command-line benchmarking tool.
- [![Open-Source Software][oss icon]](https://github.com/orhun/kmon) [kmon](https://kmon.cli.rs/) - Linux Kernel Manager and Activity Monitor.
- [![Open-Source Software][oss icon]](https://github.com/dylanaraps/neofetch) [Neofetch](https://github.com/dylanaraps/neofetch) - A fast, highly customizable system info script that supports Linux, MacOS, iOS, BSD, Solaris, Android, Haiku, GNU Hurd, MINIX, AIX and Windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave it, and mention it's discontinued, and people should look at Fastfetch

README.md Outdated
@@ -1620,12 +1620,12 @@ _For a more comprehensive/advanced/better categorized/... list of Linux audio so
- [![Open-Source Software][oss icon]](https://github.com/ClementTsang/bottom) [bottom](https://clementtsang.github.io/bottom/nightly/) - Yet another cross-platform graphical process/system monitor.
- [![Open-Source Software][oss icon]](https://github.com/aristocratos/bpytop) [bpytop](https://github.com/aristocratos/bpytop) - Resource monitor that shows usage and stats for processor, memory, disks, network and processes. Python port and continuation of bashtop.
- [![Open-Source Software][oss icon]](https://github.com/aristocratos/btop) [btop](https://github.com/aristocratos/btop) - Resource monitor that shows usage and stats for processor, memory, disks, network and processes.
- [![Open-Source Software][oss icon]](https://github.com/fastfetch-cli/fastfetch) [Fastfetch](https://github.com/fastfetch-cli/fastfetch/) - Fastfetch is a neofetch-like tool for fetching system information and displaying it prettily. It is written mainly in C, with performance and customizability in mind.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neofetch was supporting bunch of OS.

I didn't check at fastfetch, but I would expect to list a few of them if the number of OS is smaller.

This could be another reason to keep Neofetch listed also.

Discontinued doesn't mean broken, it means it's not maintained, but it works (for now, and probably a few more years)

Copy link
Contributor Author

@sonic2kk sonic2kk Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the difference in respect to OS support, and while I agree that discontinued doesn't mean broken, is there not precedent for removing archived / discontinued projects? For example, #741 which removed projects that no longer work due to API changes (namely, Twitter) but also removed Atom, which may still work, but is archived. A search of PRs for "discontinued" yields more PRs that removed discontinued software, in some cases where the repository was archived and in others where the website was unreachable (#752).

Having said that, some distributions, such as Arch Linux, still package Neofetch, to my surprise.

I can keep it if there is preference to keep discontinued software in general, perhaps with a caveat that it is discontinued, or if we want to make a special exception here. Neofetch does seem like a bit of an edge-case where it was not discontinued due to a third-party change (e.g. an API change) or slowly phased out (e.g. Atom) so keeping Neofetch with a caveat could be more of an exception rather than adhering to a guideline about how to include software.

Not trying to be argumentative, simply justifying the rationale for removing it based on prior PRs for similar cases, but I can understand if we might want to make an exception for Neofetch.

Copy link
Owner

@luong-komorebi luong-komorebi Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some opinion:

  • this list does not try to be a museum and I would rather focus on putting an app that both works and is maintained up there rather than trying to keep track of all software ever created.
  • we should not retain the old archived listing when there is a newer and maintained fork. While I agree that "Discontinued doesn't mean broken", that is a deduction rather than explicit point on the homepage of neofetch. And checkout the list of issues or issue like this clearly shows that this software is far from being complete
  • the multiple OS support is a valid argument, but as long as fast fetch has official linux installation option, it is already qualified (let alone they support multiple distributions already and are only missing a few others)

Therefore, I am ok with replacing the old one

Co-authored-by: ccoVeille <[email protected]>
@luong-komorebi luong-komorebi merged commit 45858f9 into luong-komorebi:master Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants