Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config dialog and new property #2

Merged
merged 3 commits into from
Oct 28, 2018

Conversation

mothsART
Copy link

I propose a new dialog who edit config file and a new property who displaying notification or not.

@lusum
Copy link
Owner

lusum commented Oct 25, 2018

I try it before merge it.

@lusum
Copy link
Owner

lusum commented Oct 25, 2018

The commit give me an error:

File "./gSpeech.py", line 677, in
config = Config(CONFIGFILE)
File "./gSpeech.py", line 595, in init
'shownotification'
File "/usr/lib/python2.7/ConfigParser.py", line 368, in getboolean
v = self.get(section, option)
File "/usr/lib/python2.7/ConfigParser.py", line 618, in get
raise NoOptionError(option, section)
ConfigParser.NoOptionError: No option 'shownotification' in section: 'CONFIGURATION'

maybe you have added a section in gspeech.conf and you haven't added it in the pull request?

@mothsART
Copy link
Author

Right : i forgot testing with an empty section on gspeech.conf => resolved.

@lusum
Copy link
Owner

lusum commented Oct 26, 2018

Can you add a section in gspeech.conf? Like Useappindicator = True. It shuld be better to distribute a complete gspeech.conf

@lusum
Copy link
Owner

lusum commented Oct 26, 2018

Different line numbers, but same error:

Traceback (most recent call last):
File "./gSpeech.py", line 678, in
config = Config(CONFIGFILE)
File "./gSpeech.py", line 596, in init
'shownotification'
File "/usr/lib/python2.7/ConfigParser.py", line 368, in getboolean
v = self.get(section, option)
File "/usr/lib/python2.7/ConfigParser.py", line 618, in get
raise NoOptionError(option, section)
ConfigParser.NoOptionError: No option 'shownotification' in section: 'CONFIGURATION'

@mothsART
Copy link
Author

mothsART commented Oct 26, 2018

@lusum : I add a property, not a section.
Same strack trace but different error : i change "has_section" by "has_option" : https://docs.python.org/2/library/configparser.html#ConfigParser.RawConfigParser.has_option : check existence of section and property.

@lusum
Copy link
Owner

lusum commented Oct 28, 2018

It works so i commit it

@lusum lusum merged commit dae4d77 into lusum:master Oct 28, 2018
@mothsART
Copy link
Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants