Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First cli script #4

Merged
merged 10 commits into from
Mar 8, 2020
Merged

First cli script #4

merged 10 commits into from
Mar 8, 2020

Conversation

mothsART
Copy link

@mothsART mothsART commented Mar 5, 2020

No description provided.

@lusum
Copy link
Owner

lusum commented Mar 7, 2020

Sorry to be late, i will try and i will commit your patch,

@lusum
Copy link
Owner

lusum commented Mar 7, 2020

please change the error messages from french to english, english is the base language for translations in this project

It also would be needed an explication like a switch --help to explain how this script works, maybe with an option to set the language and not only french without modify the config file

@mothsART
Copy link
Author

mothsART commented Mar 7, 2020

You're absolutely right.
To achieve my goals, I preferred to split into several files.
Is very hard for me too keep a big monolithique file, surely because I would like to add some unit tests in a next iteration.

So, i added :

  1. gitignore entry
  2. errors messages in english
  3. --help and --version options
  4. forcing a language selection without update config file
  5. some PEP8 migration : variables in UPPERCASE or camelCase are very ugly in python.
    migrate on snake_case
  6. factorisation

@lusum
Copy link
Owner

lusum commented Mar 8, 2020

Ok, i commit this patch , but i will fix some minor problems

@lusum lusum merged commit 56b8c67 into lusum:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants