fix(worker): do not clean up workers in loop __gc #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis6991
force-pushed
the
fix/luaworkgc
branch
4 times, most recently
from
535d7d3 to
6ddf2c3
Compare
When setting up luv with luaopen_luv(), instead of cleaning up workers in the __gc of the loop (which luv may not own), instead create an empty userdata with a worker __gc and attach it to the lua_State. Fixes luvit#754
lewis6991
force-pushed
the
fix/luaworkgc
branch
from
6ddf2c3 to
1a96b46
Compare
|
Looks like this fixes the ASAN issue: https://github.com/neovim/neovim/actions/runs/13033954809?pr=32174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up luv with luaopen_luv(), instead of cleaning up workers
in the __gc of the loop (which luv may not own), instead create an empty
userdata with a worker __gc and attach it to the lua_State.
Fixes #754