Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urdf loader humble #347

Merged
merged 26 commits into from
Sep 1, 2023
Merged

Urdf loader humble #347

merged 26 commits into from
Sep 1, 2023

Conversation

Serafadam
Copy link
Collaborator

@Serafadam Serafadam commented Jul 4, 2023

Overview

Author: @Serafadam

Issue

Issue link (if present): #98 and more
Issue description: Publish accurate sensor transforms based on calibration data and refactor how and which urdf is launched.
Related PRs

Changes

ROS distro: Humble
List of changes:

  • Add TFPublisher class (will move it later to depthai_bridge) to publish static transforms
  • URDF in depthai_descriptions publishes only the initial frames & mesh
  • Still need to figure out options and parameters for the TF publisher

Testing

Hardware used: OAK-D PRO
Depthai library version: 2.22

Visuals from testing

Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.

@Serafadam Serafadam requested a review from saching13 July 4, 2023 10:06
@borongyuan
Copy link
Contributor

borongyuan commented Jul 9, 2023

Hi @Serafadam ,
Could you add imu frame for other camera models to urdf? This is what we really need.
For dm9098 (OAK-D S2 & OAK-D Pro), since the imu extrinsics does not exist in calibration data, I measured the following parameters from the pcb file.

<joint name="$(arg camera_name)_imu_joint" type="fixed">
    <parent link="$(arg base_frame)"/>
    <child  link="$(arg camera_name)_imu_frame"/>
    <origin xyz="-0.008 -0.037945 -0.00079" rpy="${pi} ${pi/2} 0" />
</joint>

For ng9097 (PoE models):

<joint name="$(arg camera_name)_imu_joint" type="fixed">
    <parent link="$(arg base_frame)"/>
    <child  link="$(arg camera_name)_imu_frame"/>
    <origin xyz="-0.008 -0.04 -0.020265" rpy="${pi} ${pi/2} 0" />
</joint>

@Serafadam Serafadam marked this pull request as ready for review August 21, 2023 14:27
@Serafadam Serafadam merged commit eca7bae into humble Sep 1, 2023
6 checks passed
@Serafadam Serafadam deleted the urdf_loader_humble branch September 1, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants