php 8.1 issue for empty server url

luyadev · Sep 13, 2023 · 4ab3c76 · 4ab3c76
1 parent 8158d4c
commit 4ab3c76
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -14,7 +14,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
+        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
 
     steps:
       ## checkout the repoistory 
@@ -36,7 +36,7 @@ jobs:
       ## run unit tests
       - name: PHP Unit tests for PHP 
         run: vendor/bin/phpunit --verbose --configuration actions.phpunit.xml
-        if: matrix.php == '8.2' || matrix.php == '8.1' || matrix.php == '8.0' || matrix.php == '7.4' || matrix.php == '7.3'
+        if: matrix.php == '8.3' || matrix.php == '8.2' || matrix.php == '8.1' || matrix.php == '8.0' || matrix.php == '7.4' || matrix.php == '7.3'
 
       ## unit test with coverage
       - name: PHP Unit tests for PHP 7.2

diff --git a/src/base/AbstractRequestClient.php b/src/base/AbstractRequestClient.php
@@ -211,7 +211,7 @@ public function setEndpoint($endpoint)
      */
     public function getRequestUrl()
     {
-        $parts = [rtrim($this->client->serverUrl, '/'), $this->client->language, ltrim((string) $this->endpoint, '/')];
+        $parts = [rtrim((string) $this->client->serverUrl, '/'), $this->client->language, ltrim((string) $this->endpoint, '/')];
 
         $url = implode("/", array_filter($parts));