Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVCON-6849] First part of new flow of adhoc mode #727

Merged
merged 20 commits into from
Mar 8, 2024
Merged

Conversation

smonero
Copy link
Contributor

@smonero smonero commented Feb 29, 2024

Change summary:

  • create server.go in server/neptune/admin, this has NewServer(...), Start(), shutdown(), buildTerraformWorker(), and Healthz()
  • modify user_config.go and tests to accomodate adminMode
  • modify server.go in cmd to have new admin flow
  • also create admin.go in cmd which has a func called NewServer() which then calls admin.NewServer(...)

@smonero smonero changed the title first [DEVCON-6849] First part of new flow of terraformadmin mode Feb 29, 2024
Copy link
Contributor

@samrabelachew samrabelachew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting to look at this, I'm of the opinion that we approach these changes by just injecting what we need to the new server rather than the opposite approach of adding all functionality and removing pieces later on.

Copy link
Contributor

@samrabelachew samrabelachew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice start, took a first past let me know if you have questions

cmd/server.go Outdated Show resolved Hide resolved
cmd/terraformadmin.go Outdated Show resolved Hide resolved
cmd/terraformadmin.go Outdated Show resolved Hide resolved
server/neptune/terraformadmin/server.go Outdated Show resolved Hide resolved
server/neptune/terraformadmin/server.go Outdated Show resolved Hide resolved
server/neptune/terraformadmin/server.go Outdated Show resolved Hide resolved
cmd/terraformadmin.go Outdated Show resolved Hide resolved
cmd/terraformadmin.go Outdated Show resolved Hide resolved
server/neptune/admin/config/adminconfig.go Outdated Show resolved Hide resolved
cmd/admin.go Outdated Show resolved Hide resolved
cmd/admin.go Show resolved Hide resolved
server/config/raw/global_cfg.go Outdated Show resolved Hide resolved
server/neptune/admin/server.go Outdated Show resolved Hide resolved
@smonero smonero changed the title [DEVCON-6849] First part of new flow of terraformadmin mode [DEVCON-6849] First part of new flow of adhoc mode Mar 7, 2024
@smonero smonero merged commit 2a0da82 into main Mar 8, 2024
3 checks passed
@smonero smonero deleted the firstStepOfNewFlow branch March 8, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants