-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVCON-6849] First part of new flow of adhoc mode #727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting to look at this, I'm of the opinion that we approach these changes by just injecting what we need to the new server rather than the opposite approach of adding all functionality and removing pieces later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice start, took a first past let me know if you have questions
Change summary:
server.go
in server/neptune/admin, this hasNewServer(...)
,Start()
,shutdown()
,buildTerraformWorker()
, andHealthz()
adminMode
server.go
in cmd to have new admin flowadmin.go
in cmd which has a func called NewServer() which then calls admin.NewServer(...)