This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Fix concurrent modifcation exception when destroying scoops #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
buildbreaker
force-pushed
the
scoop-destruction-concurrency
branch
from
237334a to
ca38ac5
Compare
|
👍 |
|
🚀 |
| final Set<Map.Entry<String, Scoop>> entries = this.children.entrySet(); | ||
|
|
||
| final Set<Map.Entry<String, Scoop>> entriesCopy = new HashSet<>(entries); | ||
| for (Map.Entry<String, Scoop> entry : entriesCopy) { |
There was a problem hiding this comment.
@buildbreaker This could be simplified
for (Scoop value : entriesCopy.values()) {
value.destroy();
}
Or iterate over a list of scoops:
List<Scoop> valuesCopy = new ArrayList(entries.values())
It's already merged though so it's ok.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.