This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Unify appRouter and dialogRouter #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathyma
force-pushed
the
unify-flows
branch
7 times, most recently
from
eecf3c1 to
638bade
Compare
|
|
||
| @Controller(DialogController.class) | ||
| @DaggerModule(DialogModule.class) | ||
| @EnterTransition(SlideUpTransition.class) | ||
| @ExitTransition(SlideDownTransition.class) | ||
| public class Dialog extends Screen { | ||
| private byte[] backgroundBitmap; | ||
|
|
||
| public void setBackground(BitmapDrawable backgroundDrawable) { |
There was a problem hiding this comment.
Who should ideally be the one calling this method?
It seems that we are relying on the transition to handle this but I'm not convinced that is the right decision
There was a problem hiding this comment.
The dialog controller is the one calling it right now as it's the one responsible for storing/restoring state. The transition is only responsible for capturing the state before the transition happens and sets the to view accordingly. I considered moving it to UIContainer, but this seems too specific of a view property (BitmapDrawable background) to store/restore on a framework level.
a screenshot of the previous view.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.