Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some ICE connectivity issues #1641

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Oct 5, 2020

Description

I've been investigating some issues that led to having different ICE states between browser and Erizo in some cases. Some of the issues were solved here, while others need to be fixed in nICEr (I'm also preparing a PR there).

The major issue was that Erizo considered all Host candidates as failed because they were using their private IP network, even if we define a Public IP one. For those cases, we now automatically add the Public IP as the Host candidates' address when it is set in the config file.

As part of this work, I've been experimenting a bit with ICE-LITE. I haven't completed it yet because it is low priority, as Firefox does not seem to support ICE-LITE MCUs. The good news is that I've solved some issues that I found during the process.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@@ -112,7 +112,7 @@ int NicerConnection::ice_connected(void *obj, nr_ice_peer_ctx *pctx) {
}
conn->updateIceState(IceState::READY);
conn->nicer_->IceContextFinalize(conn->ctx_, pctx);

conn->nicer_->IcePeerContextDumpState(pctx, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants