-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PMTiles support #4
Conversation
docs: > | ||
Geometry and web map links (PMTiles) from SpatioTemporal Asset Catalog (STAC) Collections can be rendered as layer group. | ||
|
||
Note: The example doesn't work in Firefox due to restrictive CORS rules at the data host. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either:
- mirror the data in this GH repo or in some CORS-friendly bucket for other STAC assets
- I can mirror this at a stable url like r2-public.protomaps.com/stac/foo.pmtiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be great, indeed!
LGTM, examples work for me after I published ol-pmtiles 0.2.0 |
@m-mohr are we blocked merging this until protomaps/PMTiles#112 is done? It seems like in its current state it will only support PMTiles in public buckets with appropriate CORS headers. If we change Any rework of the PMTiles js itself (not ol-pmtiles) has a longer timeline... |
Thanks. Not blocking, I just need to document it. But I also still want to find a better way to configure the sources generally, because the current way with so many |
I refactored the source creation. So as long as I'd be able to pass the headers via the source options, I'd be fine. Anyway, this can be merged, I think. The way it's handled here is now pretty much independant of the underlying implementation. Implementors need to check how the source options look like and adapt their implementation accordingly. |
Depends on: