Android fixes #13

mbender74 · 2022-06-17T12:12:30Z

Fixes for FragmentManager: No view found for id 0x2 (unknown) for fragment SupportMapFragment tidev#282
and corrections now the mapView works as expected
Feat: added code for offlineOverlay image tiles like my PR soon to be done for iOS for offlineOverlay map features....

android/src/ti/map/ViewProxy.java

m1ga · 2022-06-17T12:14:47Z

android/src/ti/map/ViewProxy.java

+
+		TiUIView mapview = new TiUIMapView(this, activity);
+
+		// ((TiUIMapView) view).createMapFragment();


remove the comment if not needed

m1ga · 2022-06-17T12:15:07Z

android/src/ti/map/ViewProxy.java

@@ -1226,7 +1238,8 @@ private float handleGetZoomLevel()
 	public void setLocation(Object location)
 	{
 		if (location instanceof HashMap) {
-			HashMap dict = (HashMap) location;
+			HashMap<String, Object> dict = new HashMap<>();
+			dict.put("", location);


well, that way no warnings from compiler because of wrong hashmap type

if that has to be diffrent, I don´t know :-D

the warning: [rawtypes] found raw type: HashMap warnings have been there the whole time. If you make a ti clean and build again you'll see many other warnings like

HashMap centerOffsetProperty = (HashMap) anno.getProperty(MapModule.PROPERTY_CENTER_OFFSET); [ERROR] [GRADLE] ^ [ERROR] [GRADLE] missing type arguments for generic class HashMap<K,V>

but it still builds fine. I would rather keep the part from before and we fix those warnings at another point. I've not tested setLocation but dict.put("", location); doesn't look right either 🤣

m1ga · 2022-06-17T12:15:59Z

why did you do the PR on my fork 😄 ?

mbender74 · 2022-06-17T12:18:22Z

var mapView = mapModule.createView({
			id:'mapview',
			userLocation: true,
			minZoom:14,
			maxZoom:18,
			mapType: Map.SATELLITE_TYPE,
			animate: false,
			region: {
				latitude: 49.54119,
				longitude: 7.33233,
				latitudeDelta: parseFloat((parseFloat(49.5487)-parseFloat(49.5300))/2),
				longitudeDelta: parseFloat((parseFloat(7.3453)-parseFloat(7.3170))/2),
			},
			offlineOverlay: {
				tilesPath:'/maps/tiles',
				tileExtension:'jpg',
				tileSize:256,
				maxRegion: {
					minLat:49.5300,
					maxLat:49.5487,
					minLong:7.3170,
					maxLong:7.3453,
					maxZoom:18,
					minZoom:14
				}
			},
			pitchEnabled: true,
			rotateEnabled: true,
			compassEnabled: true,
			showsBuildings: true,
			showsPointsOfInterest: true,
			top:0,
			bottom:0,
			left:0,
			right:0,
			width: Ti.UI.FILL,
			height: Ti.UI.FILL,
		});

maps.zip

mbender74 · 2022-06-17T12:18:49Z

because you need to test first

mbender74 · 2022-06-17T12:19:15Z

will do on main repo if found for good :-)

mbender74 · 2022-06-17T12:21:43Z

this fragment bug, also with your further improvements, which did not take any properties, just rendering the world.... take me hours over hours... this morning, I finally get it to work :-)

This reverts commit 4910630.

mbender74

comments removed

mbender74 · 2022-06-17T12:38:20Z

in the maps.zip are demo map tiles, that will show the offlineOverlay feature

m1ga · 2022-06-17T12:52:17Z

offline tiles work fine. Make sure to add the properties to the docs (https://github.com/m1ga/ti.map/blob/master/apidoc/View.yml).
Can't test the other issue since it wasn't my bug.
I've created this issue: tidev#480 which still won't work and it will only show one map.

because you need to test first

but my fork is not up to date (only one PR with iOS stuff) and I can test it from your fork or the official repo too 😄 This only makes me double the work since I have to test it here and in the tidev repo. I rather prefer doing the PR in the main repo right way or no PR and just use your fork until its ready 😉

mbender74 · 2022-06-17T13:03:23Z

ok, I will also check if I can fix tidev#480
and then I will push to official....

m1ga

left some comments. In case you don't use Android Studio: use it 😄 makes it easier to spot unused variables and imports!

m1ga · 2022-06-20T16:05:49Z

android/src/ti/map/CustomMapFragment.java

+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;


unused imports

m1ga · 2022-06-20T16:06:05Z

android/src/ti/map/CustomMapFragment.java

+	// @Override
+	// public View onCreateView(LayoutInflater arg0, ViewGroup arg1, Bundle arg2) {
+	//       Log.e(TAG, " onCreateView");
+	//       View v = super.onCreateView(arg0, arg1, arg2);
+	//       return v;
+	// }


remove if not needed

m1ga · 2022-06-20T16:07:39Z

android/src/ti/map/TiUIMapView.java

+	private float maxZoomPreference = 20;
+	private LatLngBounds boundingRegion;
+	private Context mainContext;
+	private GroundOverlay overlayBackground;


m1ga · 2022-06-20T16:07:54Z

android/src/ti/map/TiUIMapView.java

+	private Context mainContext;
+	private GroundOverlay overlayBackground;
+	private Integer backgroundColor = null;
+	private boolean transactionCommitted = false;


m1ga · 2022-06-20T16:09:21Z

android/src/ti/map/TiUIMapView.java

+		mapView = new MapView(proxy.getActivity(), gOptions);
+		container.addView(mapView);
+		mapView.onCreate(Bundle.EMPTY);
+		mapView.onResume();


is that onResume needed?

m1ga · 2022-06-20T16:13:16Z

android/src/ti/map/TiUIMapView.java

+	// Intercept the touch event to find out the correct clicksource if clicking
+	// on the info window.
+	protected boolean interceptTouchEvent(MotionEvent ev)
+	{
+		if (ev.getAction() == MotionEvent.ACTION_UP && selectedAnnotation != null) {
+			TiMapInfoWindow infoWindow = selectedAnnotation.getMapInfoWindow();
+			TiMarker timarker = selectedAnnotation.getTiMarker();
+			if (infoWindow != null && timarker != null) {
+				Marker marker = timarker.getMarker();
+				if (map != null && marker != null && marker.isInfoWindowShown()) {
+					Point markerPoint = map.getProjection().toScreenLocation(marker.getPosition());
+					infoWindow.analyzeTouchEvent(ev, markerPoint, selectedAnnotation.getIconImageHeight());
+				}
+			}
+		}
+		return false;
+	}
+


why did you move that function? Unnecessary change 😄

m1ga · 2022-06-20T16:14:22Z

android/src/ti/map/TilesOfflineTileProvider.java

+import android.content.res.AssetFileDescriptor;
+import android.graphics.Bitmap;
+import android.graphics.Bitmap.CompressFormat;
+import android.graphics.BitmapFactory;
+import android.os.AsyncTask;
+import android.os.Environment;
+import android.os.Handler;
+import android.os.Message;
+import com.google.android.gms.maps.model.Tile;
+import com.google.android.gms.maps.model.TileProvider;
+import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.FileDescriptor;
+import java.io.FileInputStream;
+import java.io.IOException;
+import org.appcelerator.kroll.KrollDict;
+import org.appcelerator.kroll.common.AsyncResult;
+import org.appcelerator.kroll.common.Log;
+import org.appcelerator.kroll.common.TiMessenger;
+import org.appcelerator.titanium.TiApplication;
+import org.appcelerator.titanium.TiC;
+import org.appcelerator.titanium.io.TiBaseFile;
+import org.appcelerator.titanium.io.TiFileFactory;
+import org.appcelerator.titanium.io.TiFileProvider;
+import org.appcelerator.titanium.proxy.TiViewProxy;
+import org.appcelerator.titanium.util.TiFileHelper2;
+import org.appcelerator.titanium.util.TiRHelper;
+import org.appcelerator.titanium.view.TiDrawableReference;


only

import android.graphics.Bitmap; import com.google.android.gms.maps.model.Tile; import com.google.android.gms.maps.model.TileProvider; import org.appcelerator.titanium.proxy.TiViewProxy; import org.appcelerator.titanium.view.TiDrawableReference; import java.io.ByteArrayOutputStream;

are used

m1ga · 2022-06-20T16:15:49Z

android/src/ti/map/ViewProxy.java

+		TiUIView view = new TiUIMapView(this);
+		return view;


remove the variable and just return new...

mbender74 and others added 4 commits September 13, 2021 19:48

fixed build settings

e05a5c3

Merge branch 'tidev:master' into master

444ed02

fix(android): no view found for id

da53181

Update titanium.xcconfig

9f091ed

m1ga reviewed Jun 17, 2022

View reviewed changes

mbender74 added 4 commits June 17, 2022 14:26

chore: removed comments

4910630

Revert "chore: removed comments"

082e36c

This reverts commit 4910630.

chore: removed comments and put back original createview return value

f9a101b

Merge remote-tracking branch 'origin/android-fixes' into android-fixes

2e3d260

mbender74 commented Jun 17, 2022

View reviewed changes

mbender74 marked this pull request as draft June 17, 2022 12:37

fix(android): multiple maps working now

a118c6e

m1ga reviewed Jun 20, 2022

View reviewed changes

fix(android): cleanup

01dce45

mbender74 closed this Jun 21, 2022

mbender74 deleted the android-fixes branch June 21, 2022 17:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android fixes #13

Android fixes #13

mbender74 commented Jun 17, 2022

m1ga Jun 17, 2022

m1ga Jun 17, 2022

mbender74 Jun 17, 2022

mbender74 Jun 17, 2022

m1ga Jun 17, 2022

m1ga commented Jun 17, 2022

mbender74 commented Jun 17, 2022

mbender74 commented Jun 17, 2022

mbender74 commented Jun 17, 2022

mbender74 commented Jun 17, 2022

mbender74 left a comment

mbender74 commented Jun 17, 2022

m1ga commented Jun 17, 2022

mbender74 commented Jun 17, 2022

m1ga left a comment

m1ga Jun 20, 2022

m1ga Jun 20, 2022

m1ga Jun 20, 2022

m1ga Jun 20, 2022

m1ga Jun 20, 2022 •

edited

Loading

m1ga Jun 20, 2022

m1ga Jun 20, 2022

m1ga Jun 20, 2022


		TiUIView mapview = new TiUIMapView(this, activity);

		// ((TiUIMapView) view).createMapFragment();

Android fixes #13

Android fixes #13

Conversation

mbender74 commented Jun 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m1ga commented Jun 17, 2022

mbender74 commented Jun 17, 2022

mbender74 commented Jun 17, 2022

mbender74 commented Jun 17, 2022

mbender74 commented Jun 17, 2022

mbender74 left a comment

Choose a reason for hiding this comment

mbender74 commented Jun 17, 2022

m1ga commented Jun 17, 2022

mbender74 commented Jun 17, 2022

m1ga left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m1ga Jun 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m1ga Jun 20, 2022 •

edited

Loading