Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addLabels is ignored by the ProgressBar #472

Closed
4 of 8 tasks
Cube707 opened this issue Nov 28, 2024 · 0 comments · Fixed by #473
Closed
4 of 8 tasks

addLabels is ignored by the ProgressBar #472

Cube707 opened this issue Nov 28, 2024 · 0 comments · Fixed by #473
Labels
bug Undesired behavior caused by this plugin

Comments

@Cube707
Copy link
Contributor

Cube707 commented Nov 28, 2024

Please fill out these Check-boxes

  • I checked for existing similar issues
  • I checked that the plugin is up to date
  • The issue persists with all other plugins and themes disabled

Plugin Version

1.2.5

This Issue Occurs on

  • Windows
  • Linux
  • macOS
  • Android
  • iOS

Debug Info

SYSTEM INFO:
	Obsidian version: v1.7.7
	Installer version: v1.7.7
	Operating system: Windows 10 Enterprise 10.0.19045
	Login status: not logged in
	Language: en
	Insider build toggle: off
	Live preview: on
	Base theme: adapt to system
	Community theme: none
	Snippets enabled: 1
	Restricted mode: off
	Plugins installed: 2
	Plugins enabled: 2
		1: Meta Bind v1.2.5
		2: JS Engine v0.1.20

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Describe the Issue

Using the addLabels porpertie on a progressBar input has no effect.

Steps to Reproduce


```meta-bind
INPUT[progressBar(addLabels(true))]
```
```meta-bind
INPUT[progressBar(addLabels(false))]
```

Both produce the exact same result.

Expected Behavior

As documentded, using addLabels(false) should hide the labels.

Additional Info

The option is loaded into the swelt-component same as in the slider, it's just never used:

I am happy to provide a PR for this, I am just not sure if all three labels should be hidden or just the left and right one (leaving the current value displayed)

<span class="mb-progress-bar-value">{value}</span>
<span class="mb-progress-bar-label-left">{props.minValue}</span>
<span class="mb-progress-bar-label-right">{props.maxValue}</span>

{#if props.addLabels}
<span class="mb-slider-input-label">{props.maxValue}</span>
{/if}

@Cube707 Cube707 added the bug Undesired behavior caused by this plugin label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behavior caused by this plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant