Fix addLabels having no effect for progressBar
#473
Conversation
Cube707
changed the title
addLabelshavving no effect for progressBaraddLabels having no effect for progressBar
|
Not sure. I would say no, as otherwise there is no way of knowing what the value of the progress bar is when the labels are hidden. |
I was thinking, that maybe one explicitly only want the visual feedback while handling the numeric values separately via a textbox? The slider also has only the visual feedback with labels of, so it might be more consistent? |
|
for reference, this is what I currently work on (here I hid the labels via CSS) |
|
Fair. I think no labels at all are fine. |
|
Maybe a tooltip on hover is a good idea though. This can simply be done by setting an |
the left and right labels are now hidden if `addLabeld(false)` is used, same as on slider
Cube707
force-pushed
the
fix/addlabels-progressbar
branch
from
287cb34 to
a7c2487
Compare
| @@ -125,9 +125,12 @@ | |||
| aria-valuemin={props.minValue} | |||
| aria-valuemax={props.maxValue} | |||
| aria-valuenow={value} | |||
| aria-label={value} | |||
There was a problem hiding this comment.
I experimented a bit with with switching to aria-labeledby in case the labels are shown, but could get it to work. also this required a unique ID on the mb-progress-bar-value which adds unnecessary overhead
|
thanks |
I implemented the fix, but am unsure if all three lables should be hidden or if the center one should be left
closes #472