Refactor mantis-remote-observable 3rd party dependency specifications

first pass at refactor 3rd party dependency specifications for mantis-remote-observable and corresponding changes to root build.gradle. (issue Netflix#345)
mabelbot · Mar 2, 2023 · 60d8cf2 · 60d8cf2
1 parent ea7a19f
commit 60d8cf2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/build.gradle b/build.gradle
@@ -61,6 +61,7 @@ ext.versions = [
         mqlVersion : '3.4.+',
         nettyVersion : "4.1.34.Final",
         parquetVersion : "1.12.0",
+        rxJavaMathVersion : "0.20.6",
         rxJavaReactiveStreamsVersion : '1.+',
         scalaBinaryVersion : '2.12',
         snappyVersion : "1.1.+",
@@ -139,6 +140,7 @@ ext.libraries = [
         nettyHandler   : "io.netty:netty-handler:${versions.nettyVersion}",
         parquetHadoop  : "org.apache.parquet:parquet-hadoop:${versions.parquetVersion}",
         rxJava         : "io.reactivex:rxjava:1.3.8",
+        rxJavaMath     : "com.netflix.rxjava:rxjava-math:${versions.rxJavaMathVersion}",
         rxJavaReactiveStreams : "io.reactivex:rxjava-reactive-streams:${versions.rxJavaReactiveStreamsVersion}",
         rxNettyShaded  : "com.netflix:mantis-rxnetty:0.4.19.1",
         slf4jApi       : "org.slf4j:slf4j-api:${versions.slf4j}",

diff --git a/mantis-remote-observable/build.gradle b/mantis-remote-observable/build.gradle
@@ -14,19 +14,15 @@
  * limitations under the License.
  */
 
-ext {
-    nettyVersion = '4.1.17.Final'
-    rxJavaMathVersion = '0.20.6'
-}
 
 test {
     exclude 'io/reactivex/mantis/remote/observable/**'  // exclude remote observable tests that require ports
 }
 
 dependencies {
     implementation project(':mantis-common')
-    implementation "io.netty:netty-handler:$nettyVersion"
-    implementation("com.netflix.rxjava:rxjava-math:$rxJavaMathVersion") {
+    implementation libraries.nettyHandler
+    implementation(libraries.rxJavaMath) {
         exclude module: 'rxjava-core'
     }
     implementation libraries.slf4jApi