Refactor mantis-examples-mantis-publish-sample 3rd party dependency s…

…pecifications first pass at refactor 3rd party dependency specifications for mantis-examples-mantis-publish-sample and corresponding changes to root build.gradle (issue Netflix#345)
mabelbot · Mar 2, 2023 · bc0ad96 · bc0ad96
1 parent f74ba90
commit bc0ad96
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/build.gradle b/build.gradle
@@ -65,6 +65,7 @@ ext.versions = [
         mesosVersion : '1.7.2',
         mockito  : "2.18.+",
         mockito3 : "3.+",
+        mockNeatVersion : '0.4.8',
         mqlVersion : '3.4.+',
         nettyVersion3 : '3.7.0.Final',
         nettyVersion : "4.1.34.Final",
@@ -162,7 +163,7 @@ ext.libraries = [
         mockitoAll     : "org.mockito:mockito-all:${versions.mockito}",
         mockitoCore    : "org.mockito:mockito-core:${versions.mockito}",
         mockitoCore3   : "org.mockito:mockito-core:${versions.mockito3}",
-        mockneat       : "net.andreinc:mockneat:0.4.8",
+        mockneat       : "net.andreinc:mockneat:${versions.mockneatVersion}",
         mqlJvm         : "io.mantisrx:mql-jvm:${versions.mqlVersion}",
         netty          : "io.netty:netty:${versions.nettyVersion}",
         nettyAll       : "io.netty:netty-all:${versions.nettyVersion}",
@@ -184,6 +185,7 @@ ext.libraries = [
         spectatorApi0 : "com.netflix.spectator:spectator-api:0.134.0",
         spectatorExtIpc0: "com.netflix.spectator:spectator-ext-ipc:0.134.0",
         spectatorPlugin: "com.netflix.spectator:spectator-nflx-plugin:${versions.spectatorVersion}",
+        spectatorPlugin0: "com.netflix.spectator:spectator-nflx-plugin:0.134.0",
         spotifyFutures : "com.spotify:completable-futures:0.3.1",
         testng         : "org.testng:testng:${versions.testngVersion}",
         vavr           : "io.vavr:vavr:${versions.vavr}",

diff --git a/mantis-examples/mantis-examples-mantis-publish-sample/build.gradle b/mantis-examples/mantis-examples-mantis-publish-sample/build.gradle
@@ -45,23 +45,17 @@ application {
     mainClassName = 'com.netflix.mantis.examples.mantispublishsample.Application'
 }
 
-ext {
-    guiceVersion = '4.2.2'
-    spectatorVersion = '0.96.0'
-    archaiusVersion = 'latest.release'
-    mockNeatVersion = '0.4.8'
-}
 
 
 dependencies {
     implementation project(":mantis-publish:mantis-publish-netty-guice")
 
     implementation libraries.rxJava
-    implementation "com.netflix.spectator:spectator-ext-ipc:$spectatorVersion"
-    implementation "com.netflix.archaius:archaius2-core:$archaiusVersion"
-    implementation "com.netflix.archaius:archaius2-guice:$archaiusVersion"
-    implementation "com.google.inject:guice:$guiceVersion"
-    implementation "com.netflix.spectator:spectator-nflx-plugin:$spectatorVersion"
+    implementation libraries.spectatorExtIpc0
+    implementation libraries.archaius2Core
+    implementation libraries.archaius2Guice
+    implementation libraries.guice
+    implementation libraries.spectatorPlugin0
     implementation libraries.mockneat
 
     implementation libraries.slf4jLog4j12