-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Picker24/feature/generic binning and return kinematic parameter tidy #169
Draft: Picker24/feature/generic binning and return kinematic parameter tidy #169
Conversation
- also removes useless inlines
Slim down to two virtual functions. Now the job of the caller to convert string parameter names to subclass-specific integer identifiers. ReturnKinematicParameterByReference now actually returns by reference.
Adds a new format for binning definitions: ```yaml Binning: Axes: - VarStr: "RecoNeutrinoEnergy" VarBins: [0., 0.5, 1., 1.25, 1.5, 1.75, 2., 2.25, 2.5, 2.75, 3., 3.25, 3.5, 3.75, 4., 5., 6., 10.] - VarStr: "ERecQE" Uniform: [10, 0, 10] - VarStr: "EHadRec" Uniform: [10, 0, 10] ``` To the rest of MaCh3 this will appear like a 1D analysis, where the analysis variable is the global bin number. When using this option, the XVarStr is set to "global_bin_number", which must be implemented by all SamplePDF sub classes that want to use this feature. We can integrate this into Core more directly in the future, but for now, I think this works. 'flow bins in the ND binning are ignored, the 1D binning runs from [-0.5,nbins-0.5]. The 'default' ROOT 'flow bins exist on the 1D binning and so the global bin finder method returns a value of -1 for a over/under flow on any individual axis.
Hi, @luketpickering, By that time enjoy this meme 👇 , hope you like it 😄 Use this action on your projects. Use jokes on issues instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is your first PR, thank you for contributing to MaCh3!
- if you have a xscov that defines spline parameters, but you don't define any spline file name templates on your sample, try not to crash.
- slice function implementations on the way! - probably this is now enough 'binning' code that it shouldn't just live in SamplePDF
…face - to view/interrogate histograms, 1D global bin number histograms are useless see samplePDF/GenericBinningTools.h for interface
- also fixes confusing axis name when making 1D global bin number plot
…inematicParameterTidy
CI which has ROOT compiled with c++14 is failing: Which is related to bumping c++ standard. This isn't no stopper but probably should discuss on gneral meeting if everyone is fine or if there are poeple who will be affected by this change etc |
Pull request description
changes ahead of new MaCh3 core merge.
Changes or fixes
Examples
New ND binning option