tidy: Step Scale Sanity chekc et. al. #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggested on based on literautre
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
github-actions
bot
added
Documentation
pjdunne
reviewed
Dec 18, 2024
| MACH3LOG_ERROR("You are trying so set StepScale to 0 this will not work"); | ||
| throw MaCh3Exception(__FILE__ , __LINE__ ); | ||
| } | ||
| MACH3LOG_INFO("{} setStepScale() = {}", getName(), scale); | ||
| const double SuggestedScale = 2.38*2.38/_fNumPar; | ||
| if(std::fabs(scale - SuggestedScale)/SuggestedScale > 1) { |
There was a problem hiding this comment.
This won't warn you if you go too small right? ie scale=0 won't throw an error. Maybe make it >0.8?
There was a problem hiding this comment.
Case scale = 0 is handle separately just above this check. Atlhough we don't have any checks for negative so will update it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
We often use defined step scale. However we know based on literature what it should be. Now simply throw warning if step scale is very different. This should help spot mistakes.
Changes or fixes
Examples