breaking: Less stinky Cov Osc #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
github-actions
bot
added
Plotting
KSkwarczynski
requested review from
henry-wallace-phys and
ewanwm
as code owners
Merged
ewanwm
approved these changes
Jan 7, 2025
| @@ -32,7 +32,6 @@ class covarianceBase { | |||
| /// @brief Destructor | |||
| virtual ~covarianceBase(); | |||
|
|
|||
| // Setters | |||
There was a problem hiding this comment.
A truly next level nit-pick, but could do a \defgroup Setters here to group the setters and keep the doxygen a little bit tidier https://www.doxygen.nl/manual/grouping.html
covariance/covarianceBase.h
Outdated
| @@ -103,7 +106,7 @@ class covarianceBase { | |||
| void RandomConfiguration(); | |||
|
|
|||
| /// @brief Check if parameters were proposed outside physical boundary | |||
| virtual int CheckBounds(); | |||
| int CheckBounds(); | |||
There was a problem hiding this comment.
could make this function const?
covariance/covarianceBase.h
Outdated
Comment on lines
317
to
322
| void printNominal(); | ||
| /// @brief Print prior, current and proposed value for each parameter | ||
| void printNominalCurrProp(); | ||
| void printPars(); | ||
| /// @warning only for backward compatibility | ||
| /// @todo remove it | ||
| void printPars() {printNominalCurrProp();}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Plenty of tidy to cov classes
Changes or fixes
Examples