Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: linking splines on ubuntu #277

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

KSkwarczynski
Copy link
Member

Pull request description

This is problem

/usr/bin/ld: ../_deps/mach3-build/splines/libSplines.so: undefined reference to covarianceXsec::GetSplineParsNamesFromDetID[abi:cxx11](int)'
/usr/bin/ld: ../_deps/mach3-build/splines/libSplines.so: undefined reference to covarianceXsec::GetSplineInterpolationFromDetID(int)'
/usr/bin/ld: ../_deps/mach3-build/splines/libSplines.so: undefined reference to covarianceXsec::GetGlobalSystIndexFromDetID(int, SystType)'
/usr/bin/ld: ../_deps/mach3-build/splines/libSplines.so: undefined reference to covarianceXsec::GetNumParamsFromDetID(int, SystType)'
/usr/bin/ld: ../_deps/mach3-build/splines/libSplines.so: undefined reference to covarianceXsec::GetSplineModeVecFromDetID(int)'

Problem is Splines depend on Covariance, so had to change linking order. Porblem only appeared for ubuntu

Changes or fixes

Examples

Before

After

@KSkwarczynski KSkwarczynski self-assigned this Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions bot added Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples labels Jan 8, 2025
@KSkwarczynski KSkwarczynski merged commit 08e2ebb into develop Jan 8, 2025
14 of 15 checks passed
@KSkwarczynski KSkwarczynski deleted the feature_UbinutLinking branch January 8, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant