Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Safer Yaml openning #281

Merged
merged 3 commits into from
Jan 10, 2025
Merged

feat: Safer Yaml openning #281

merged 3 commits into from
Jan 10, 2025

Conversation

KSkwarczynski
Copy link
Member

Pull request description

Introduce new wrapper around YAML::LoadFile, whole implementation is being handled by yaml, but by having wrapper we can easily intorudce additional checks and in case of error we can pass file, line which should make debugging much easier

Changes or fixes

  • test_stat is no longer member of manager. For example we use manager for samplePDF cofnig. In this case test_stat make no sense. Now we have simply getter so all code should work fine

Examples

plot

Copy link

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions bot added Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples Manager GPU labels Jan 10, 2025
Copy link

Hi, I am MaCh3-Telemetry bot

Memory and CPU Usage Summary

### Memory and CPU Usage Summary

| Metric  |     Mean    |      Max    |
|---------|-------------|-------------|
| **RAM** |   312.73 MB |   317.02 MB |
| **CPU** |    92.85 %  |   128.25 %  |

Memory Usage Plot

You can view the memory usage plot directly in the job summary from the link above.

Copy link
Contributor

@dbarrow257 dbarrow257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbarrow257 dbarrow257 merged commit 8f99c8c into develop Jan 10, 2025
14 of 15 checks passed
@dbarrow257 dbarrow257 deleted the feature_YamlOpen branch January 10, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GPU Manager Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants