tidy: ROOT includes #286
Merged
tidy: ROOT includes #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSkwarczynski
requested review from
ewanwm,
EdAtkin and
dbarrow257
as code owners
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
github-actions
bot
added
Documentation
|
Hi, I am MaCh3-Telemetry bot Memory and CPU Usage SummaryMemory Usage PlotYou can view the memory usage plot directly in the job summary from the link above. |
ewanwm
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
What is this used for? is it needed if it compiled ok before?
There was a problem hiding this comment.
This was breaking DUNE compilation after the previous CMake cleanup. It's required for linking to TVector3 and TLorentzVector (among other things).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
While testing MaCh3 on one of clusters I coudln't compile code due to ROOT header only funciton being compiled with MaCh3 very restrictive Werror.
In future we should have better treamtnet of external headers but right now let's throw such protection
Such protection is neccessary for all ROOT headers as every user has access to sliglhy different ROOT version
Changes or fixes
Examples