Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Manager Factory #290

Merged
merged 4 commits into from
Jan 20, 2025
Merged

feat: Manager Factory #290

merged 4 commits into from
Jan 20, 2025

Conversation

KSkwarczynski
Copy link
Member

@KSkwarczynski KSkwarczynski commented Jan 14, 2025

Pull request description

New manager factory inspired by random chat with Henry some time ago.

Main motivation is to allow override config via comand line.
Normally one would have to change config to change filename.
This feature allow to do stuff like this
./bin/MCMCTutorial Inputs/FitterConfig.yaml General:OutputFile:blarb.root

Which should be super handy if running running batch jobes

Changes or fixes

Examples

blarb blarb2

Warning after Dan't comment
image

@KSkwarczynski KSkwarczynski self-assigned this Jan 14, 2025
Copy link

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions bot added MCMC MCMC related Manager labels Jan 14, 2025
Copy link

Hi, I am MaCh3-Telemetry bot

Memory and CPU Usage Summary

### Memory and CPU Usage Summary

| Metric  |     Mean    |      Max    |
|---------|-------------|-------------|
| **RAM** |   311.01 MB |   315.11 MB |
| **CPU** |    91.75 %  |   119.25 %  |

Memory Usage Plot

You can view the memory usage plot directly in the job summary from the link above.

@KSkwarczynski KSkwarczynski merged commit c9ff44f into develop Jan 20, 2025
13 of 14 checks passed
@KSkwarczynski KSkwarczynski deleted the feature_ManagerFactory branch January 20, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manager MCMC MCMC related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant