Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Move throw to within expected if statement in splineFDBase dimension checking #303

Merged
merged 1 commit into from
Jan 24, 2025
Merged

bugfix: Move throw to within expected if statement in splineFDBase dimension checking #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion samplePDF/samplePDFFDBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,6 @@ void samplePDFFDBase::fillArray_MP() {
}
//DB - Second, check to see if the event is outside of the binning range and skip event if it is
else if (XVar < XBinEdges[0] || XVar >= XBinEdges[nXBins]) {
MACH3LOG_WARN("XVAR BEYOND BIN EDGES!!");
continue;
}
//DB - Thirdly, check the adjacent bins first as Eb+CC+EScale shifts aren't likely to move an Erec more than 1bin width
Expand Down
2 changes: 1 addition & 1 deletion splines/splineFDBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,8 @@ std::vector<TAxis *> splineFDBase::FindSplineBinning(std::string FileName, std::
if (Dimensions[iSample] != 2)
{
MACH3LOG_ERROR("Trying to load a 2D spline template when nDim={}", Dimensions[iSample]);
}
throw MaCh3Exception(__FILE__, __LINE__);
}
//Hist2D = std::unique_ptr<TH2F>(File->Get<TH2F>("dev_tmp_0_0"));
Hist2D = File->Get<TH2F>(TemplateName.c_str());
}
Expand Down
Loading