Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for using spot instances #210

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Conversation

tverghis
Copy link
Contributor

@tverghis tverghis commented Jan 22, 2025

This is almost a 1:1 copy of #171, all credits/attribution for the work go to @troinine. It appears that they opened the original PR over a year ago at this point but haven't been able to get it merged. This is simply the same PR, but against the latest main branch.

I've successfully been able to provision a runner on a Spot instance using this patch as recently as today.

cc @Preen who I think is the maintainer of this repo now?

Closes #169

@tverghis tverghis changed the title Spot instance feat: support for using spot instances Jan 22, 2025
@Preen
Copy link
Collaborator

Preen commented Jan 22, 2025

Very nice job. I have tested it and it works (ARM, AMD both non-spot and spot), will create a new tag and release it.

@Preen Preen merged commit 28fbe1c into machulav:main Jan 22, 2025
@tverghis tverghis mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Allow requesting spot instance instead of an on-demand instance.
2 participants