Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel incompatibility between SDK and framework #249

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tosuke
Copy link
Contributor

@tosuke tosuke commented Dec 27, 2024

Output from acceptance testing:

$ MACKEREL_EXPERIMENTAL_TFFRAMEWORK=1 make testacc TESTS='TestAcc.+Channel'
TF_ACC=1 go test -v ./... -run TestAcc.+Channel -timeout 120m
?       github.com/mackerelio-labs/terraform-provider-mackerel  [no test files]
testing: warning: no tests to run
PASS
ok      github.com/mackerelio-labs/terraform-provider-mackerel/internal/mackerel        0.271s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/mackerelio-labs/terraform-provider-mackerel/internal/planmodifierutil        0.428s [no tests to run]
=== RUN   TestAccCompat_MackerelChannelResource_Email
=== PAUSE TestAccCompat_MackerelChannelResource_Email
=== RUN   TestAccCompat_MackerelChannelResource_Slack
=== PAUSE TestAccCompat_MackerelChannelResource_Slack
=== RUN   TestAccCompat_MackerelChannelResource_Webhook
=== PAUSE TestAccCompat_MackerelChannelResource_Webhook
=== CONT  TestAccCompat_MackerelChannelResource_Email
=== CONT  TestAccCompat_MackerelChannelResource_Webhook
=== CONT  TestAccCompat_MackerelChannelResource_Slack
--- PASS: TestAccCompat_MackerelChannelResource_Webhook (7.02s)
--- PASS: TestAccCompat_MackerelChannelResource_Email (7.35s)
--- PASS: TestAccCompat_MackerelChannelResource_Slack (7.38s)
PASS
ok      github.com/mackerelio-labs/terraform-provider-mackerel/internal/provider        7.924s
testing: warning: no tests to run
PASS
ok      github.com/mackerelio-labs/terraform-provider-mackerel/internal/typeutil        0.217s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/mackerelio-labs/terraform-provider-mackerel/internal/validatorutil   0.958s [no tests to run]
2025/01/16 15:44:43 [INFO] mackerel: use terraform-plugin-framework based implementation
=== RUN   TestAccDataSourceMackerelChannelEmail
=== PAUSE TestAccDataSourceMackerelChannelEmail
=== RUN   TestAccDataSourceMackerelChannelSlack
=== PAUSE TestAccDataSourceMackerelChannelSlack
=== RUN   TestAccDataSourceMackerelChannelWebhook
=== PAUSE TestAccDataSourceMackerelChannelWebhook
=== RUN   TestAccDataSourceMackerelChannelNotMatchAnyChannel
=== PAUSE TestAccDataSourceMackerelChannelNotMatchAnyChannel
=== RUN   TestAccMackerelChannel_Email
=== PAUSE TestAccMackerelChannel_Email
=== RUN   TestAccMackerelChannel_Slack
=== PAUSE TestAccMackerelChannel_Slack
=== RUN   TestAccMackerelChannel_Webhook
=== PAUSE TestAccMackerelChannel_Webhook
=== CONT  TestAccDataSourceMackerelChannelEmail
=== CONT  TestAccMackerelChannel_Email
=== CONT  TestAccDataSourceMackerelChannelWebhook
=== CONT  TestAccDataSourceMackerelChannelNotMatchAnyChannel
=== CONT  TestAccMackerelChannel_Webhook
=== CONT  TestAccMackerelChannel_Slack
=== CONT  TestAccDataSourceMackerelChannelSlack
--- PASS: TestAccDataSourceMackerelChannelNotMatchAnyChannel (1.19s)
--- PASS: TestAccDataSourceMackerelChannelEmail (2.89s)
--- PASS: TestAccDataSourceMackerelChannelSlack (2.98s)
--- PASS: TestAccDataSourceMackerelChannelWebhook (2.98s)
--- PASS: TestAccMackerelChannel_Email (5.19s)
--- PASS: TestAccMackerelChannel_Slack (5.35s)
--- PASS: TestAccMackerelChannel_Webhook (5.51s)
PASS
ok      github.com/mackerelio-labs/terraform-provider-mackerel/mackerel 6.365s

@tosuke tosuke changed the base branch from main to nil-relax December 27, 2024 08:46
Base automatically changed from nil-relax to main January 14, 2025 05:42
@tosuke tosuke marked this pull request as ready for review January 14, 2025 05:50
@tosuke tosuke marked this pull request as draft January 16, 2025 05:53
@tosuke tosuke marked this pull request as ready for review January 16, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant