Improve condition checks

macopedia · Aug 30, 2019 · 0332f7f · 0332f7f
1 parent bedcc5a
commit 0332f7f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/Console/Command/CategoriesCommand.php b/Console/Command/CategoriesCommand.php
@@ -179,15 +179,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 }
             }
 
-            foreach ($this->baseParentCategories as $category) {
+            foreach (!empty($this->baseParentCategories) ? $this->baseParentCategories : [] as $category) {
                 $this->addOrUpdateCategory($category, true);
             }
 
-            foreach ($this->childCategories as $category) {
+            foreach (!empty($this->childCategories) ? $this->childCategories : [] as $category) {
                 $this->addOrUpdateCategory($category);
             }
 
-            if (count($this->errors) > 0) {
+            if (!empty($this->errors)) {
                 $output->writeln('There was ' . count($this->errors) . ' errors:');
                 foreach ($this->errors as $error) {
                     $output->writeln($error);
@@ -314,4 +314,4 @@ protected function mapHeaders($row)
             }
         }
     }
-}
+}